There are many shades of yellow contacts to choose from, but if you have dark eyes you will typically want to go with the theatrical yellow contacts because this will usually cover your entire eye, and so it won’t really matter what color your eyes are. If you are buying yellow contacts they will usually be for Halloween and other types of costume parties, so this should be what you are looking for already.
If you are only looking for accents you can go with the standard yellow contacts that will usually only add a small tint to your eyes, they will sometimes be referred to as amber. You can find these year round and they are great for adding a little extra something to your dark brown or light brown eyes.
Ultimately the color of the contacts, the style and the color your natural eyes are all factors in determining if the yellow contacts will work for your dark eyes, but typically the costume, and theatrical contact lenses will always do a better color covering your natural eye color.